-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SoundCloud Export & Lookup #147
Conversation
I updated this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The api calls should use linked_partitioning=true
where relevant, the format of the JSON response changes if you pass the query param so be sure to test the patches again and update the code that accesses the JSON.
You can find an example here of how to paginate with linked_partitioning: https://github.com/metabrainz/listenbrainz-server/blob/f0334debe2b003cc36a6d94765442bf3be0a34d5/listenbrainz/metadata_cache/soundcloud/handler.py#L66-L109.
Also, the code to use soundcloud export using CLI was missing. I added it myself because I needed it for testing. |
@amCap1712 Thanks for the feedback! Working on it. Completely forgot about cli, will add them to others then |
@amCap1712 hi! I updated the code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once these changes are done, I'll do a retest to ensure playlist exports work and then we can merge it.
@amCap1712 Thanks for your feedback! I've implemented all the changes you requested. I also made some additional tweaks and identified a few errors. The The only thing I'm facing is that the Labs Lookup api retrieves soundcloud ids for only a limited number of songs, which makes testing a bit difficult |
a28e460
to
bb2df12
Compare
PR Status: In Progress
Developed a SoundCloud API class to manage SoundCloud interactions.
Implemented SoundCloud lookup features, including:
test lookup functionality
test rate limits